Clean up current "Build" step #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingerartur
force-pushed
the
feat/DE-6746-pipeline
branch
from
e936e26 to
7153e80
Compare
fingerartur
force-pushed
the
feat/DE-6746-pipeline
branch
2 times, most recently
from
8222622 to
d1b4030
Compare
fingerartur
force-pushed
the
feat/DE-6746-pipeline
branch
from
0e05f86 to
b9824cb
Compare
|
Will do. I deleted what I could from GitHub including this comment from
you, in order not to draw attention to it. But I cannot delete the PR
itself, that does not seem to be possible in GitHub.
…On Tue, Nov 21, 2023 at 1:56 PM Thasso Griebel ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In .github/workflows/publish.yml
<#17 (comment)>
:
> + # TODO remove the --dry-run
+ - name: Publish to NPM
+ run: npm publish --dry-run
+
+ - name: Add NPM Release Job summary
+ run: |
+ echo '### NPM Release' >> $GITHUB_STEP_SUMMARY
+ echo "Released version ${{ env.VERSION }} of ***@***.***/prestoplay-react-components" >> $GITHUB_STEP_SUMMARY
+
+ - name: Build Storybook
+ run: npm run build-storybook
+
+ - name: Assume AWS role
+ uses: ***@***.***
+ with:
+ role-to-assume: arn:aws:iam::068037490145:role/prestoplay-web-web-uploader
@fingerartur <https://github.com/fingerartur> I got some feedback from
@amphied <https://github.com/amphied> on this one and re recommended to
move this to a secret or at least a variable
—
Reply to this email directly, view it on GitHub
<#17 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFYSKJB4Z55HQICPWE7SUB3YFSJIJAVCNFSM6AAAAAA7SXALOGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBRHAYDGNJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
*Artur Finger* | Javascript Software Developer, PRESTOplay Team
***@***.***
[image: castLabs]
castlabs.com | @castlabs <https://twitter.com/castlabs> | LinkedIn
<https://www.linkedin.com/company/castlabs>
castLabs GmbH, Wilhelmine-Gemberg-Weg 5-7, 10179 Berlin, Germany | Managing
Directors: Michael Stattmann, Martin Tews | Amtsgericht
Berlin-Charlottenburg HRB 101555 B
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.